Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --pid=container in run command #1358

Closed
wants to merge 1 commit into from
Closed

add --pid=container in run command #1358

wants to merge 1 commit into from

Conversation

minuk-dev
Copy link
Contributor

@minuk-dev minuk-dev commented Sep 6, 2022

Signed-off-by: Min Uk Lee minuk.dev@gmail.com

#1293
references:


Why this pr is draft pr?

  • For getting container's pid, this function needs a containerd.Client instance. It preallocated in createContainer() cmd/nerdctl/run.go#L385.
  • But, should all setPlatformOptions() be changed to pass this variable? I'm not sure about it.
    • Does anyone have any idea?

Signed-off-by: Min Uk Lee <minuk.dev@gmail.com>
@minuk-dev minuk-dev changed the title add --pid=container in run command #1293 add --pid=container in run command Sep 6, 2022
@minuk-dev
Copy link
Contributor Author

There is some bugs about UID and GID mappings.
Please just ignore this pr. I'm really sorry.

@minuk-dev minuk-dev closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant