Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #1411 especially, #1411 (comment), #1411 (review)
Changes
withInternalLabels()
incmd/nerdctl/run.go
setPlatformContainerOptions()
Details
Simplify
withInternalLabels()
incmd/nerdctl/run.go
Delete
setPlatformContainerOptions()
:setPlatformContainerOptions()
be created by processing an internalLabel (PIDContainer supporting--pid=container:<name or id>
) for linux. But as the structure for internalLabel is created, it is not needed.setPlatformContainerOptions()
andsetPlatformOptions()
query the container twice.setPlatformContainerOptions()
and pass a new parameter intosetPlatformOptions()
for platform specific labels.