Filter dangling images using image filters. #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manugupt1
force-pushed
the
filter-dangling-images
branch
from
829ba87
to
a682aa1
Compare
AkihiroSuda
reviewed
Dec 31, 2022
AkihiroSuda
reviewed
Dec 31, 2022
AkihiroSuda
reviewed
Dec 31, 2022
AkihiroSuda
reviewed
Dec 31, 2022
| @@ -369,7 +370,7 @@ func ParseRepoTag(imgName string) (string, string) { | |||
|
|
|||
| ref, err := refdocker.ParseDockerRef(imgName) | |||
| if err != nil { | |||
| logrus.WithError(err).Warnf("unparsable image name %q", imgName) | |||
| logrus.WithError(err).Debugf("unparsable image name %q", imgName) | |||
There was a problem hiding this comment.
Every time there is a <none> image listed out; this Warning is printed out; I think we should not do it; now that we are adding more support for dangling images.
manugupt1
force-pushed
the
filter-dangling-images
branch
from
a682aa1
to
48175ee
Compare
Signed-off-by: Manu Gupta <manugupt1@gmail.com>
manugupt1
force-pushed
the
filter-dangling-images
branch
from
48175ee
to
9d79e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manu Gupta manugupt1@gmail.com