[Refactor] Refactor network list #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djdongjin
suggested changes
Jan 15, 2023
cmd/nerdctl/network_ls.go
Outdated
| } | ||
| if f, ok := w.(formatter.Flusher); ok { | ||
| return f.Flush() | ||
| options := &types.NetworkListCommandOptions{ |
There was a problem hiding this comment.
can you change to non-pointer return type?
cmd/nerdctl/network_ls.go
Outdated
| } | ||
| return nil | ||
| return network.List(options, cmd.OutOrStdout()) |
There was a problem hiding this comment.
we probably should add a context.Context argument and pass in cmd.Context(), similar to
Line 133 in cfe96a9
yzxiu
changed the title
Signed-off-by: yaozhenxiu <946666800@qq.com>
AkihiroSuda
approved these changes
Jan 16, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1680
Checklist:
Signed-off-by: yaozhenxiu 946666800@qq.com