Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Refactor images pull command #1852

Merged
merged 1 commit into from
Jan 19, 2023
Merged

[Refactor] Refactor images pull command #1852

merged 1 commit into from
Jan 19, 2023

Conversation

suyanhanx
Copy link
Contributor

@suyanhanx suyanhanx commented Jan 14, 2023 •
edited
Loading

part of #1680

Checklist:

  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Signed-off-by: suyanhanx suyanhanx@gmail.com

@yuchanns yuchanns self-requested a review January 14, 2023 08:47
@suyanhanx suyanhanx marked this pull request as draft January 14, 2023 09:40
Zheaoli
Zheaoli reviewed Jan 14, 2023
View reviewed changes
cmd/nerdctl/pull.go Outdated Show resolved Hide resolved
cmd/nerdctl/pull.go Outdated Show resolved Hide resolved
cmd/nerdctl/pull.go Outdated Show resolved Hide resolved
@suyanhanx suyanhanx force-pushed the refactor-image-pull-flag branch 3 times, most recently from a0a9657 to f6cb4e8 Compare January 15, 2023 13:22
@suyanhanx suyanhanx marked this pull request as ready for review January 15, 2023 13:58
@suyanhanx suyanhanx requested review from Zheaoli and yuchanns and removed request for yuchanns and Zheaoli January 15, 2023 13:59
djdongjin
djdongjin reviewed Jan 15, 2023
View reviewed changes
cmd/nerdctl/run.go Outdated Show resolved Hide resolved
pkg/cmd/image/pull.go Outdated Show resolved Hide resolved
@Zheaoli Zheaoli added this to the v1.2.0 milestone Jan 16, 2023
djdongjin
djdongjin reviewed Jan 18, 2023
View reviewed changes
cmd/nerdctl/run.go Outdated Show resolved Hide resolved
@suyanhanx
refactor image pull flag
eada6de 
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx requested review from djdongjin and removed request for Zheaoli January 18, 2023 02:32
djdongjin
djdongjin approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@djdongjin djdongjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green

Zheaoli
Zheaoli approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on CI green

@ktock ktock merged commit 6af0dcf into containerd:main Jan 19, 2023
@suyanhanx suyanhanx deleted the refactor-image-pull-flag branch January 19, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zheaoli Zheaoli Zheaoli approved these changes

@yuchanns yuchanns yuchanns approved these changes

@djdongjin djdongjin djdongjin approved these changes

@ktock ktock ktock approved these changes

Assignees
No one assigned
Labels
kind/refactor
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suyanhanx @Zheaoli @yuchanns @djdongjin @ktock