Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(container): refactor cp flag #1930

Merged
merged 1 commit into from
Feb 21, 2023
Merged

refactor(container): refactor cp flag #1930

merged 1 commit into from
Feb 21, 2023

Conversation

MimeLyc
Copy link
Contributor

@MimeLyc MimeLyc commented Jan 26, 2023

Part of: #1680

Checklist:

  • Create a file in pkg/api/types/${cmd}_types.go, and define the CommandOption for this command
  • Create some file in pkg/cmd/${cmd}, and move the command entry point in real into this package

Signed-off-by: Yuchao.Li mimelyc@gmail.com

@MimeLyc MimeLyc marked this pull request as draft January 26, 2023 08:45
@MimeLyc MimeLyc marked this pull request as ready for review January 26, 2023 12:36
@MimeLyc
Copy link
Contributor Author

MimeLyc commented Jan 26, 2023

Hey~ This's my first time submitting a PR to this project, I hope I do it the right way.

I can't figure out how to pass the Wondows/containerd-1.6 check using the log,
Please let me know if I am doing something wrong！🙏🏻

@MimeLyc MimeLyc force-pushed the refactor_cp_flag branch 2 times, most recently from 5f966ea to 96b2f93 Compare January 29, 2023 02:11
@MimeLyc MimeLyc requested review from djdongjin and AkihiroSuda and removed request for djdongjin and AkihiroSuda January 29, 2023 09:13
djdongjin
djdongjin reviewed Jan 29, 2023
View reviewed changes
cmd/nerdctl/container_cp_linux.go Outdated Show resolved Hide resolved
cmd/nerdctl/container_cp_linux.go Outdated Show resolved Hide resolved
pkg/cmd/container/cp_linux.go Outdated Show resolved Hide resolved
pkg/containerutil/cp_linux.go Outdated Show resolved Hide resolved
@MimeLyc MimeLyc force-pushed the refactor_cp_flag branch 2 times, most recently from 07fd92f to 035a326 Compare January 30, 2023 06:15
djdongjin
djdongjin reviewed Jan 30, 2023
View reviewed changes
pkg/api/types/container_types.go Outdated Show resolved Hide resolved
pkg/cmd/container/cp_linux.go Show resolved Hide resolved
@MimeLyc MimeLyc force-pushed the refactor_cp_flag branch 4 times, most recently from b52fd29 to 8f0f420 Compare February 2, 2023 15:42
@AkihiroSuda
Copy link
Member

Please clean up commit logs

@MimeLyc MimeLyc force-pushed the refactor_cp_flag branch 3 times, most recently from e48bd25 to 855c66d Compare February 20, 2023 13:31
@MimeLyc
Copy link
Contributor Author

MimeLyc commented Feb 20, 2023

Please clean up commit logs

@AkihiroSuda
Sorry, it was my fault. I have cleaned up the commit history now.

There are often errors in the CI that are not caused by the changes in this PR. I'm unsure if I should keep trying to retry or wait for the main branch to be fixed.

@MimeLyc
refactor(container): refactor cp flag
ef06dcb 
Signed-off-by: Yuchao.Li <mimelyc@gmail.com>
@AkihiroSuda AkihiroSuda added this to the v1.2.1 milestone Feb 21, 2023
AkihiroSuda
AkihiroSuda approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit a32edce into containerd:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djdongjin djdongjin djdongjin left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
kind/refactor
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MimeLyc @AkihiroSuda @djdongjin