Refactor container prune and rename command flagging process
#1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #1680 |
|
Please split this into 2 PRs. One PR for one thing. |
Thank you very much for your guidance. This is a simple and minor change. Of course, if it does not conform to the community rules, I will split it later. |
djdongjin
reviewed
Feb 10, 2023
pkg/cmd/container/prune.go
Outdated
Comment on lines
51
to
54
| for _, id := range deleted { | ||
| fmt.Fprintln(options.Stdout, id) | ||
| } | ||
| fmt.Fprintln(options.Stdout, "") |
There was a problem hiding this comment.
nit: this can be fmt.Fprintln(options.Stdout, strings.Join(deleted, "\n")
pkg/cmd/container/rename.go
Outdated
Comment on lines
58
to
63
| n, err := walker.Walk(ctx, containerID) | ||
| if err != nil { | ||
| return err | ||
| } else if n == 0 { | ||
| return fmt.Errorf("no such container %s", containerID) | ||
| } |
There was a problem hiding this comment.
nit:
if n, err := walker.Walk(ctx, containerID); err != nil {
return err
} else if n == 0 {
return fmt.Errorf("no such container %s", containerID)
}
|
Please squash your commits. |
Signed-off-by: rkonfj <rkonfj@gmail.com>
|
@suyanhanx @djdongjin can we merge this ? |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor container
pruneandrenamecommand flagging processSigned-off-by: rkonfj rkonfj@gmail.com