Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up stargz-snapshotter to v0.6.4 #235

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

AkihiroSuda
Copy link
Member

No description provided.

@AkihiroSuda
Copy link
Member Author

Draft until actual release of v0.6.3
cc @ktock

I'll release nerdctl v0.8.3 after merging this.

@ktock
Copy link
Member

ktock commented Jun 2, 2021

@AkihiroSuda AkihiroSuda marked this pull request as ready for review June 2, 2021 09:53
@AkihiroSuda AkihiroSuda closed this Jun 2, 2021
@AkihiroSuda AkihiroSuda reopened this Jun 2, 2021
@AkihiroSuda
Copy link
Member Author

Ready for review

@AkihiroSuda
Copy link
Member Author

# github.com/hanwen/go-fuse/v2/fuse
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:224:41: undefined: GetAttrIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:225:41: undefined: SetAttrIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:228:39: undefined: MknodIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:252:42: undefined: SetXAttrIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:258:40: undefined: CreateIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:260:38: undefined: ReadIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:269:39: undefined: WriteIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:278:41: undefined: ReadIn
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/types.go:550:2: undefined: Attr
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/types.go:578:2: undefined: Attr
Error: ../../../go/pkg/mod/github.com/hanwen/go-fuse/v2@v2.1.0/fuse/api.go:278:41: too many errors

I guess I have to defer this PR after v0.8.3

@ktock
Copy link
Member

ktock commented Jun 2, 2021

I guess I have to defer this PR after v0.8.3

Sorry for that. Sure. I'm looking deeper into it.

@AkihiroSuda
Copy link
Member Author

The error is only happening for Windows build, so we can fix the issue on this repo

@ktock
Copy link
Member

ktock commented Jun 2, 2021

This seems because nativeconverter imports go-fuse via github.com/containerd/stargz-snapshotter/store and go-fuse doesn't allow to built on windows. containerd/stargz-snapshotter#333 fixes this dependency issue.

Could we release v0.8.3 after containerd/stargz-snapshotter#333 tagged with v0.6.4? Or should we defer this PR after v0.8.3? nevermind. missed https://github.com/containerd/nerdctl/releases/tag/v0.8.3 is already out.

@AkihiroSuda AkihiroSuda marked this pull request as draft June 2, 2021 12:34
@ktock
Copy link
Member

ktock commented Jun 2, 2021

Released stargz snapshotter v0.6.4 https://github.com/containerd/stargz-snapshotter/releases/tag/v0.6.4

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title bump up stargz-snapshotter to v0.6.3 bump up stargz-snapshotter to v0.6.4 Jun 3, 2021
@AkihiroSuda AkihiroSuda marked this pull request as ready for review June 3, 2021 06:08
@AkihiroSuda
Copy link
Member Author

Thanks, updated to v0.6.4

@AkihiroSuda AkihiroSuda merged commit 3d6fb30 into containerd:master Jun 3, 2021
@ktock
Copy link
Member

ktock commented Jun 3, 2021

@AkihiroSuda Could we have a new release tag for this commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants