-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image: dedup same platform entry #2486
Conversation
How to repro the issue? |
when listing image which was generated from criu checkpoint. see containerd/containerd#9081 |
Windows test is failing
https://github.com/containerd/nerdctl/actions/runs/6146430040/job/16700918243?pr=2486 |
Signed-off-by: zhuangqh <zhuangqhc@gmail.com>
8fe5fef
to
1e0b0bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
@AkihiroSuda I have no idea whether to dudup inside the |
Ideally deduplication should happen in |
ok, I'm committing changes to the upstream containerd repository. So hold this pr, thanks |
Still dedup here as a workaround, see containerd/containerd#9081 (comment) |
Thanks, merged |
may got duplicate value from image.Platforms interface.
we should duplicate them like ctr do
Signed-off-by: zhuangqh zhuangqhc@gmail.com