Add compose ps flags #2509
Merged
Add compose ps flags #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanghaowillow
force-pushed
the
add-compose-ps-flags
branch
2 times, most recently
from
e5a58a4
to
e7d5a5d
Compare
AkihiroSuda
reviewed
Sep 16, 2023
cmd/nerdctl/compose_ps_linux_test.go
Outdated
| ) | ||
|
|
||
| func TestComposePs(t *testing.T) { | ||
| testutil.DockerIncompatible(t) |
AkihiroSuda
reviewed
Sep 16, 2023
| @@ -68,13 +68,13 @@ volumes: | |||
|
|
|||
| // stop and restart a single service. | |||
| base.ComposeCmd("-f", comp.YAMLFullPath(), "stop", "db").AssertOK() | |||
| base.ComposeCmd("-f", comp.YAMLFullPath(), "ps", "db").AssertOutContainsAny("Exit", "exited") | |||
| base.ComposeCmd("-f", comp.YAMLFullPath(), "ps", "db", "-a").AssertOutContainsAny("Exit", "exited") | |||
There was a problem hiding this comment.
DockerIncompatible() can be now probably removed
AkihiroSuda
reviewed
Sep 16, 2023
| @@ -46,7 +46,7 @@ services: | |||
|
|
|||
| // 1.1 `compose create` should create service container (in `created` status) | |||
| base.ComposeCmd("-f", comp.YAMLFullPath(), "create").AssertOK() | |||
| base.ComposeCmd("-f", comp.YAMLFullPath(), "ps", "svc0").AssertOutContainsAny("Created", "created") | |||
| base.ComposeCmd("-f", comp.YAMLFullPath(), "ps", "svc0", "-a").AssertOutContainsAny("Created", "created") | |||
There was a problem hiding this comment.
DockerIncompatible() can be now probably removed
AkihiroSuda
reviewed
Sep 16, 2023
| composePsCommand.Flags().StringArray("status", []string{}, "Filter services by status. Values: [paused | restarting | removing | running | dead | created | exited]") | ||
| composePsCommand.Flags().BoolP("quiet", "q", false, "Only display container IDs") | ||
| composePsCommand.Flags().Bool("services", false, "Display services") | ||
| composePsCommand.Flags().BoolP("all", "a", false, "Show all containers (default shows just running)") | ||
| return composePsCommand |
There was a problem hiding this comment.
tanghaowillow
force-pushed
the
add-compose-ps-flags
branch
from
c00075f
to
190c7f8
Compare
|
Please squash commits |
Signed-off-by: tanghao <tanghao1996.seu@gmail.com>
tanghaowillow
force-pushed
the
add-compose-ps-flags
branch
from
1151829
to
1b5a986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing flags for the
compose pscommand.Fixes #2502