Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore logger output #3094

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Restore logger output #3094

merged 1 commit into from
Jun 16, 2024

Conversation

apostasie
Copy link
Contributor

Fix #3093

@apostasie
Restore logger output
f4a7e0c 
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Contributor Author

Green.

@AkihiroSuda PTAL at your convenience.

AkihiroSuda
AkihiroSuda approved these changes Jun 16, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Jun 16, 2024
@AkihiroSuda AkihiroSuda merged commit 60cf112 into containerd:main Jun 16, 2024
22 checks passed
@apostasie apostasie mentioned this pull request Jun 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

oci hook does not restore logger output after closing file, resulting in spurious error and lost messages
2 participants
@apostasie @AkihiroSuda