fix image size #310
Merged
fix image size #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
force-pushed
the
fix-images-size
branch
3 times, most recently
from
6cdffbb
to
7048508
Compare
|
@ktock done |
ktock
reviewed
Aug 9, 2021
cmd/nerdctl/images.go
Outdated
Comment on lines
179
to
189
| walkFn := func(ctx context.Context, info snapshots.Info) error { | ||
| keys[info.Name] = info.Parent | ||
| return nil | ||
| } | ||
| if err := s.Walk(ctx, walkFn); err != nil { | ||
| return 0, err | ||
| } |
There was a problem hiding this comment.
Why does it scan all snapshots? Can we walk snapshots only in the chain? I think we can do this by following parents from the topmost snapshot using Stat API.
There was a problem hiding this comment.
@ktock thank you, This is what I was looking for ==> Stat API . I made modification.
fahedouch
force-pushed
the
fix-images-size
branch
from
a03a5e8
to
9e290f3
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
fix-images-size
branch
from
9e290f3
to
c6684a7
Compare
ktock
approved these changes
Aug 11, 2021
|
CI wasn't triggered? |
AkihiroSuda
reviewed
Aug 12, 2021
| @@ -143,19 +146,51 @@ func imagesBashComplete(clicontext *cli.Context) { | |||
| bashCompleteImageNames(clicontext) | |||
| } | |||
|
|
|||
| func unpackedImageSize(ctx context.Context, clicontext *cli.Context, client *containerd.Client, i images.Image) (int64, error) { | |||
| type snapshotKey string | |||
There was a problem hiding this comment.
Why define new type just for a string?
There was a problem hiding this comment.
I have to define new local type to use it as a receiver to the add method. We cannot define the add method on non-local type string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the actual image size is equal to the ChainID size.
this PR use the Walk API and Usage on each parent of ChainID to calculate the total usage of unpacked image layers
related issue #304
Signed-off-by: fahed dorgaa fahed.dorgaa@gmail.com