implement add-hosts flag && extra_hosts #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
changed the title
fahedouch
force-pushed
the
add-hosts
branch
2 times, most recently
from
8b8374a
to
058b14c
Compare
fahedouch
changed the title
AkihiroSuda
reviewed
Sep 7, 2021
cmd/nerdctl/internal_oci_hook.go
Outdated
| Name: "add-host", | ||
| Usage: "Add a custom host-to-IP mapping (host:ip)", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Why not use labels as in other flags?
There was a problem hiding this comment.
@AkihiroSuda you mean rename add-host to labels ?
There was a problem hiding this comment.
No, using labels in https://github.com/containerd/nerdctl/blob/master/pkg/labels/labels.go
Other ocihook features use these labels
fahedouch
force-pushed
the
add-hosts
branch
3 times, most recently
from
41c20a4
to
116d735
Compare
Signed-off-by: fahed dorgaa <fahed.dorgaa@gmail.com>
fahedouch
force-pushed
the
add-hosts
branch
from
116d735
to
aa6f001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
add-hostflagextra_hostsrelated ticket #314