Add Github action to run CI on pull requests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dax McDonald <31839142+daxmc99@users.noreply.github.com>
AkihiroSuda
reviewed
Dec 12, 2020
.github/workflows/ci.yml
Outdated
| branches: | ||
| - '*' | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
Can we unify build.yml into this?
There was a problem hiding this comment.
Unified, the golangci-lint should be in a separate step though since it utilizes caching to provide better performance.
Signed-off-by: Dax McDonald <31839142+daxmc99@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw this project has a
.golangci.ymlfile already. This should enable golangci-lint to run as part of pull requests.Signed-off-by: Dax McDonald 31839142+daxmc99@users.noreply.github.com