Support local output in build #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehazlett
force-pushed
the
build-local
branch
2 times, most recently
from
e78e41c
to
87ceba8
Compare
AkihiroSuda
reviewed
Sep 27, 2021
AkihiroSuda
reviewed
Sep 27, 2021
ehazlett
force-pushed
the
build-local
branch
3 times, most recently
from
a228684
to
d3e081b
Compare
Signed-off-by: Evan Hazlett <ejhazlett@gmail.com>
ehazlett
force-pushed
the
build-local
branch
from
d3e081b
to
b41704b
Compare
AkihiroSuda
approved these changes
Sep 28, 2021
|
Thank you! |
AkihiroSuda
reviewed
Sep 30, 2021
| @@ -45,6 +45,38 @@ CMD ["echo", "nerdctl-build-test-string"] | |||
| base.Cmd("run", "--rm", imageName).AssertOutContains("nerdctl-build-test-string") | |||
| } | |||
|
|
|||
| func TestBuildLocal(t *testing.T) { | |||
| testutil.DockerIncompatible(t) | |||
There was a problem hiding this comment.
Without it the test errored with not compatible. I'm assuming that's because the regular docker build doesn't support "output" (it's in buildx).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
--outputfor build allowing different types of output (oci, local, etc).