Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print message if container is not running. #44

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Print message if container is not running. #44

merged 1 commit into from
Dec 14, 2020

Conversation

shishir-a412ed
Copy link
Contributor

Signed-off-by: Shishir Mahajan smahajan@roblox.com

@shishir-a412ed
Print message if container is not running.
66d33b6 
Signed-off-by: Shishir Mahajan <smahajan@roblox.com>
@shishir-a412ed
Copy link
Contributor Author

Catching up a bit late on #41 changes, but IMO we should keep the behavior closer to docker behavior.

This is docker behavior when we try to kill a stopped container.

SM-smahajan628:~ smahajan$ docker kill 1ed12c6567b8
Error response from daemon: Cannot kill container: 1ed12c6567b8: Container 1ed12c6567b81a2ad417a464fcee7fcacd6e4c7dae956985233f1bfec5afb269 is not running

/cc @AkihiroSuda @fuweid

@AkihiroSuda AkihiroSuda merged commit b6c45a3 into containerd:master Dec 14, 2020
@shishir-a412ed shishir-a412ed deleted the kill_msg branch December 16, 2020 16:51
@cyxinda cyxinda mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shishir-a412ed @AkihiroSuda