add nerdctl images --digests (compatible with Docker, unlike ID)
#442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ktock
approved these changes
Oct 19, 2021
|
LGTM. compatibility with docker image ID will be provided by this #346 |
While the image ID is different from Docker in most cases, the DIGEST value always corresponds to Docker. ```console $ docker images --digests REPOSITORY TAG DIGEST IMAGE ID CREATED SIZE alpine latest sha256:e1c082e3d3c45cccac829840a25941e679c25d438cc8412c2fa221cf1a824e6a 14119a10abf4 7 weeks ago 5.6MB $ nerdctl images --digests REPOSITORY TAG DIGEST IMAGE ID CREATED SIZE alpine latest sha256:e1c082e3d3c45cccac829840a25941e679c25d438cc8412c2fa221cf1a824e6a e1c082e3d3c4 40 minutes ago 5.9 MiB ``` Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
nerdctl-images-digests
branch
from
5addf54
to
d47aafb
Compare
Before:
```console
$ nerdctl images
WARN[0000] unparsable image name "ghcr.io/stargz-containers/busybox@sha256:31a54a0cf86d7354788a8265f60ae6acb4b348a67efbcf7c1007dd3cf7af05ab"
REPOSITORY TAG IMAGE ID CREATED SIZE
31a54a0cf86d 15 minutes ago 1.3 MiB
```
After:
```console
$ nerdctl images
REPOSITORY TAG DIGEST IMAGE ID CREATED SIZE
ghcr.io/stargz-containers/busybox <none> sha256:31a54a0cf86d7354788a8265f60ae6acb4b348a67efbcf7c1007dd3cf7af05ab 31a54a0cf86d 22 minutes ago 1.3 MiB
```
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
nerdctl-images-digests
branch
from
d47aafb
to
a9f65bf
Compare
|
Added another commit "images: @ktock @fahedouch Still LGTY?
Thanks for working on this, but maybe we don't need to make it docker-compatible We may revisit the issue later after completing multi-platform support. |
ktock
approved these changes
Oct 19, 2021
ningmingxiao
pushed a commit
to ningmingxiao/nerdctl
that referenced
this pull request
Oct 19, 2021
…ests add `nerdctl images --digests` (compatible with Docker, unlike ID)
ningmingxiao
pushed a commit
to ningmingxiao/nerdctl
that referenced
this pull request
Oct 20, 2021
…ests add `nerdctl images --digests` (compatible with Docker, unlike ID) Signed-off-by: ning.mingxiao <ning.mingxiao@zte.com.cn>
ningmingxiao
pushed a commit
to ningmingxiao/nerdctl
that referenced
this pull request
Oct 20, 2021
…ests add `nerdctl images --digests` (compatible with Docker, unlike ID) Signed-off-by: ning.mingxiao <ning.mingxiao@zte.com.cn>
ningmingxiao
pushed a commit
to ningmingxiao/nerdctl
that referenced
this pull request
Oct 20, 2021
…ests add `nerdctl images --digests` (compatible with Docker, unlike ID) Signed-off-by: ning.mingxiao <ning.mingxiao@zte.com.cn>
ningmingxiao
pushed a commit
to ningmingxiao/nerdctl
that referenced
this pull request
Oct 20, 2021
…ests add `nerdctl images --digests` (compatible with Docker, unlike ID) Signed-off-by: ning.mingxiao <ning.mingxiao@zte.com.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: add
nerdctl images --digests(compatible with Docker, unlike ID)While the image ID is different from Docker in most cases, the DIGEST value
always corresponds to Docker.
Commit 2: images: fix
unparsable image namewarningBefore:
After: