Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run: add --tmpfs #474

Merged
merged 1 commit into from
Oct 29, 2021
Merged

run: add --tmpfs #474

merged 1 commit into from
Oct 29, 2021

Conversation

AkihiroSuda
Copy link
Member

Fix #388

@AkihiroSuda AkihiroSuda added this to the v0.13.0 milestone Oct 28, 2021
@AkihiroSuda AkihiroSuda mentioned this pull request Oct 28, 2021
Closed
@AkihiroSuda

This comment has been minimized.

Sign in to view
@AkihiroSuda AkihiroSuda marked this pull request as ready for review October 29, 2021 07:44
@AkihiroSuda
run: add --tmpfs
c93e78a 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@ktock
Copy link
Member

ktock commented Oct 29, 2021

CI fails https://github.com/containerd/nerdctl/runs/4043931547?check_suite_focus=true#step:6:324

    run_mount_test.go:190: assertion failed: 
        Command:  /usr/local/bin/nerdctl --namespace=nerdctl-test run --rm --tmpfs /tmp ghcr.io/stargz-containers/alpine:3.13-org grep /tmp /proc/mounts
        ExitCode: 0
        Stdout:   tmpfs /tmp tmpfs rw,seclabel,nosuid,nodev,noexec,relatime,inode64 0 0
        
        Stderr:   
        
        Failures:
        Expected stdout to contain "rw,nosuid,nodev,noexec"
--- FAIL: TestRunTmpfs (2.70s)

@AkihiroSuda
Copy link
Member Author

updated

@AkihiroSuda AkihiroSuda merged commit 02bcd20 into containerd:master Oct 29, 2021
@vbatts
Copy link
Contributor

vbatts commented Nov 2, 2021

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktock ktock ktock approved these changes

@fahedouch fahedouch Awaiting requested review from fahedouch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

[RFE] add nerdctl run --tmpfs </path> flag parameters
3 participants
@AkihiroSuda @ktock @vbatts