Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compose: support ulimits #593

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

junnplus
Copy link
Member

@junnplus junnplus commented Dec 3, 2021

fixed: #344

Signed-off-by: ye.sijun <junnplus@gmail.com>
@@ -78,6 +78,7 @@ func warnUnknownFields(svc compose.ServiceConfig) {
"User",
"WorkingDir",
"Volumes",
"Ulimits",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this list sorted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The list seems to have been already unsorted, so merging)

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good but a nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nerdctl compose issues with ulimit
2 participants