[Carry 556] feat: cosign sign #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com> Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com> Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
carry-556
branch
from
1a9d81a
to
fc52745
Compare
README.md
Outdated
| @@ -729,6 +734,8 @@ Usage: `nerdctl push [OPTIONS] NAME[:TAG]` | |||
| Flags: | |||
| - :nerd_face: `--platform=(amd64|arm64|...)`: Push content for a specific platform | |||
| - :nerd_face: `--all-platforms`: Push content for all platforms | |||
| - :nerd_face: `--sign`: Sign the image (none|cosign). See [`docs/cosign.md`](./docs/cosign.md) for details. | |||
| - :nerd_face: `--cosign-key`: Path to the public key file, KMS, URI or Kubernetes Secret for `--sign=cosign` | |||
There was a problem hiding this comment.
@AkihiroSuda path to the private key, and public 🙋🏻♂️
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
carry-556
branch
from
fc52745
to
3dda9f8
Compare
Closed
|
This looks great! Thank you all for the hard work. |
ktock
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carry #556
Thanks to @developer-guy @Dentrax