Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading nerdctl.toml ($NERDCTL_TOML) #635

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

AkihiroSuda
Copy link
Member

See docs/config.md

Replace PR #470

Example

# This is an example of /etc/nerdctl/nerdctl.toml .
# Unrelated to the daemon's /etc/containerd/config.toml .

debug          = false
debug_full     = false
address        = "unix:///run/k3s/containerd/containerd.sock"
namespace      = "k8s.io"
snapshotter    = "stargz"
cgroup_manager = "cgroupfs"

@AkihiroSuda AkihiroSuda added this to the v0.16.0 milestone Dec 17, 2021
@AkihiroSuda AkihiroSuda added enhancement New feature or request impact/major labels Dec 17, 2021
@AkihiroSuda AkihiroSuda changed the title Support loading nerdctl.toml Support loading nerdctl.toml ($NERDCTL_CONFIG) Dec 17, 2021
@AkihiroSuda AkihiroSuda marked this pull request as draft December 17, 2021 13:25
@ningmingxiao
Copy link
Contributor

why use “github.com/pelletier/go-toml” instead of "github.com/spf13/viper“ ?
viper support more format like JSON, TOML, YAML , if user like JSON,YAML config file it is easier to change it.
and go-toml maybe is not as strong as viper.

See `docs/config.md`

Replace PR 470

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda changed the title Support loading nerdctl.toml ($NERDCTL_CONFIG) Support loading nerdctl.toml ($NERDCTL_TOML) Dec 20, 2021
@AkihiroSuda AkihiroSuda marked this pull request as ready for review December 20, 2021 06:27
@AkihiroSuda
Copy link
Member Author

if user like JSON,YAML config file it is easier to change it.

I don't think we need such extensibility.

@AkihiroSuda AkihiroSuda merged commit fa694a8 into containerd:master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request impact/major
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants