Support /etc/containerd/certs.d/<HOST:PORT>/hosts.toml
#642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
hosts-toml
branch
8 times, most recently
from
a1ffe2b
to
d0942a3
Compare
AkihiroSuda
force-pushed
the
hosts-toml
branch
from
d0942a3
to
adc6d27
Compare
AkihiroSuda
changed the title
/etc/containerd/certs.d/<HOST:PORT>/hosts.toml/etc/containerd/certs.d/<HOST:PORT>/hosts.toml
AkihiroSuda
force-pushed
the
hosts-toml
branch
from
adc6d27
to
0a2d909
Compare
dmcgowan
reviewed
Dec 27, 2021
| if acArg == host { | ||
| if auth.RegistryToken != "" { | ||
| // Even containerd/CRI does not support RegistryToken as of v1.4.3, | ||
| // so, nobody is actually using RegistryToken? |
There was a problem hiding this comment.
It's not really necessary and the only use of it I know of was for Docker swarm. It solves the problem of sending unscoped credentials to nodes, however, the tokens end up being long lived and passed directly to registries. The better solution is using scoped refresh tokens. It would be good to support scoping somewhere here, although that does not work well with the docker login approach.
There was a problem hiding this comment.
Thanks, the current goal is to just emulate Swarm-less docker login
Closed
Closed
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
See `docs/registry.md` Fix issue 639 `nerdctl login` still ignore the hosts dir. Fixed in the next commit. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Depends on containerd/containerd PR 6396 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
hosts-toml
branch
from
0a2d909
to
2d9569e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #639
Depends on: