Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add label flag for build #653

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Conversation

junnplus
Copy link
Member

Signed-off-by: ye.sijun junnplus@gmail.com

Signed-off-by: ye.sijun <junnplus@gmail.com>
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Can we support labels in compose up --build too ?
https://pkg.go.dev/github.com/compose-spec/compose-go@v1.0.8/types#BuildConfig

@AkihiroSuda AkihiroSuda added this to the v0.16.0 milestone Dec 27, 2021
@AkihiroSuda AkihiroSuda added the enhancement New feature or request label Dec 27, 2021
@junnplus
Copy link
Member Author

Can we support labels in compose up --build too ?

Yes, I will support it in the next PR.

@AkihiroSuda AkihiroSuda merged commit ed3d553 into containerd:master Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants