remove bridge network interface after network rm #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 3, 2022
AkihiroSuda
reviewed
Jan 3, 2022
| @@ -82,6 +82,11 @@ func networkRmAction(cmd *cobra.Command, args []string) error { | |||
| if err := os.RemoveAll(l.File); err != nil { | |||
| return err | |||
| } | |||
| // Remove the bridge network interface on the host. | |||
| if l.Plugins[0].Network.Type == "bridge" { | |||
| netIf := fmt.Sprintf("nerdctl%d", *l.NerdctlID) | |||
There was a problem hiding this comment.
This should be fetched from here
nerdctl/pkg/netutil/netutil_unix.go
Line 40 in ed3d553
There was a problem hiding this comment.
It seems that there is no easy way to get the name of the bridge from plugins.
l.Plugins[0].Network.Name always is empty.
AkihiroSuda
approved these changes
Jan 3, 2022
Signed-off-by: ye.sijun <junnplus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ye.sijun junnplus@gmail.com