Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override image ENTRYPOINT on commit #667

Merged

Conversation

tomfeigin
Copy link
Contributor

@tomfeigin tomfeigin commented Jan 5, 2022

Support supplying an ENTRYPOINT to override when committing an image

@AkihiroSuda
Copy link
Member

Thanks, can we have a test?

base.Cmd("commit", "-c", `CMD ["cat", "/foo"]`, testContainer, testImage).AssertOK()
base.Cmd("run", "--rm", testImage).AssertOutExactly("hello-test-commit\n")

@AkihiroSuda
Copy link
Member

Doc needs to be updated as well

commitCommand.Flags().StringArrayP("change", "c", nil, "Apply Dockerfile instruction to the created image (only CMD directive is supported)")

https://github.com/containerd/nerdctl#whale-nerdctl-commit

@tomfeigin tomfeigin force-pushed the override_entrypoint_on_commit branch from 8fd7833 to bfe87c3 Compare January 6, 2022 09:16
Support supplying an ENTRYPOINT to override when committing an image

Signed-off-by: Tom Feigin <tom@raftt.io>
@tomfeigin tomfeigin force-pushed the override_entrypoint_on_commit branch from bfe87c3 to 09009fd Compare January 6, 2022 09:57
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit 19bc804 into containerd:master Jan 7, 2022
@AkihiroSuda AkihiroSuda added this to the v0.16.0 milestone Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants