Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nerdctl run cpuset-mems,cpu-quota,cpu-period support #689

Merged
merged 1 commit into from
Jan 11, 2022
Merged

add nerdctl run cpuset-mems,cpu-quota,cpu-period support #689

merged 1 commit into from
Jan 11, 2022

Conversation

ningmingxiao
Copy link
Contributor

@ningmingxiao ningmingxiao commented Jan 10, 2022 •
edited

Signed-off-by: ningmingxiao ning.mingxiao@zte.com.cn

@ningmingxiao ningmingxiao changed the title add cpuset-cpus cpuset-mems,cpu-quota,cpu-period add nerdctl run cpuset-cpus cpuset-mems,cpu-quota,cpu-period support Jan 10, 2022
@ningmingxiao ningmingxiao changed the title add nerdctl run cpuset-cpus cpuset-mems,cpu-quota,cpu-period support add nerdctl run cpuset-mems,cpu-quota,cpu-period support Jan 10, 2022
@fahedouch
Copy link
Member

fahedouch commented Jan 10, 2022 •
edited

Cpus and quota/period should be used seperatly. Would you plz add this condition. Plz check ctr https://github.com/containerd/containerd/blob/269548fa27e0089a8b8278fc4fc781d7f65a939b/cmd/ctr/commands/run/run_unix.go#L197

fahedouch
fahedouch requested changes Jan 10, 2022
View reviewed changes
cmd/nerdctl/run.go Outdated Show resolved Hide resolved
AkihiroSuda
AkihiroSuda requested changes Jan 11, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Command Reference in README.md, add tests to run_cgroup_linux_test.go, and squash the commits

@ningmingxiao
Copy link
Contributor Author

Please update the Command Reference in README.md, add tests to run_cgroup_linux_test.go, and squash the commits

done,thankyou

@AkihiroSuda AkihiroSuda added this to the v0.16.0 milestone Jan 11, 2022
fahedouch
fahedouch reviewed Jan 11, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ningmingxiao
add add nerdctl run cpuset-mems,cpu-quota,cpu-period support
57132f2 
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
AkihiroSuda
AkihiroSuda approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if green, thanks

@AkihiroSuda AkihiroSuda merged commit 4f91839 into containerd:master Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch requested changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request status/merge-on-green
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ningmingxiao @fahedouch @AkihiroSuda