run: automatically generate a container name from image ref #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g., `nerdctl run nginx` creates a container named "nginx-62edd". See `pkg/referenceutil/referenceutil_test.go` for more examples. The generated names are more meaningful than Docker/Podman-generated names such as "jolly_kepler". However, the generated names MUST NOT be parsed. The name can be unset by specifying `--name=""` explicitly. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
|
Let me rush this in v0.16 🙏 |
ktock
approved these changes
Jan 12, 2022
To deflake TestRunExitCode
```
=== CONT TestRunExitCode
run_test.go:113: assertion failed: 0 (int) != 1 (res.ExitCode int): time="2022-01-12T19:35:26+09:00" level=fatal msg="container \"c6476c53c0a2e092c68fb5a7faf1724eee4cb10d227
d7c6507c7766b65eaa4aa\" in namespace \"nerdctl-test\": not found"
```
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.,
nerdctl run nginxcreates a container named "nginx-62edd".See
pkg/referenceutil/referenceutil_test.gofor more examples.The generated names are more meaningful than Docker/Podman-generated names such as "jolly_kepler". However, the generated names MUST NOT be parsed.
The name can be unset by specifying
--name=""explicitly.