Add driver and opt flags for network create #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junnplus
force-pushed
the
network-driver
branch
4 times, most recently
from
ec5569b
to
e1446e3
Compare
|
@AkihiroSuda Please take a look, thanks! :) |
AkihiroSuda
reviewed
Jan 20, 2022
junnplus
force-pushed
the
network-driver
branch
2 times, most recently
from
d3bdbe1
to
ac67006
Compare
|
Windows CI failing https://cirrus-ci.com/task/5470749778509824
|
Signed-off-by: ye.sijun <junnplus@gmail.com>
junnplus
force-pushed
the
network-driver
branch
from
ac67006
to
7e0e1a0
Compare
green. |
fahedouch
reviewed
Jan 23, 2022
| return nil, err | ||
| } | ||
| default: | ||
| return nil, fmt.Errorf("unsupported network option %q", opt) |
There was a problem hiding this comment.
do you plan to support the rest of the network options (e.g com.docker.network.bridge.name) in a future PR ?
There was a problem hiding this comment.
Of course, it may take a while
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ye.sijun junnplus@gmail.com
ref: #692