Added fixes for issue #971(Mounted volume can be deleted)
#974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
click2cloud-lamda
force-pushed
the
issue971
branch
2 times, most recently
from
c7da7b8
to
cfdeb60
Compare
AkihiroSuda
changed the title
Mounted volume can be deleted)
AkihiroSuda
reviewed
Apr 12, 2022
cmd/nerdctl/volume_rm.go
Outdated
| if found = checkVolume(&mount.Mounts, volGet.Mountpoint); found { | ||
| found = true | ||
| var verr error | ||
| verr = fmt.Errorf("%s %q %s", "Volume", name, "is in use") |
AkihiroSuda
reviewed
Apr 12, 2022
cmd/nerdctl/volume_rm.go
Outdated
| return err | ||
| } | ||
| defer cancel() | ||
| containers, _ := client.Containers(ctx) |
AkihiroSuda
reviewed
Apr 12, 2022
cmd/nerdctl/volume_rm.go
Outdated
| if removednames != nil { | ||
| rNames, err := volStore.Remove(removednames) | ||
| if err != nil { | ||
| panic(err) |
click2cloud-lamda
force-pushed
the
issue971
branch
from
cfdeb60
to
a2c58e6
Compare
click2cloud-lamda
force-pushed
the
issue971
branch
2 times, most recently
from
d029bff
to
07e7a21
Compare
Zheaoli
reviewed
Apr 13, 2022
cmd/nerdctl/volume_rm.go
Outdated
| if removednames != nil { | ||
| rNames, err := volStore.Remove(removednames) | ||
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
I think just return error directly would be better
There was a problem hiding this comment.
Ill change it.
cmd/nerdctl/volume_rm.go
Outdated
| return err | ||
| } | ||
| var mount *specs.Spec | ||
| var removednames []string |
There was a problem hiding this comment.
var removedNames would be better?
There was a problem hiding this comment.
I used it for volumes that have to be deleted.
click2cloud-lamda
force-pushed
the
issue971
branch
3 times, most recently
from
4cc0d23
to
839faf5
Compare
Signed-off-by: Raymond Mathew <raymond.mathew@click2cloud.net>
AkihiroSuda
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #971
In this PR, if the volume is mounted, it doesn't allow the volume to be removed.