Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carry 643] cp cmd #995

Merged
merged 1 commit into from
Apr 21, 2022
Merged

[Carry 643] cp cmd #995

merged 1 commit into from
Apr 21, 2022

Commits on Apr 21, 2022

  1. [Carry 643] cp cmd 

    Based on Fahed Dorgaa's PR 643 but preserves the file owner information as in `docker cp`.
This implementation also avoids mixing up the `archive/tar` pkg and `tar` command.

`nerdctl cp -a` is not implemented, as the actual behavior of `docker cp -a` does not seem clearly defined.

Tests are added to to cover the conditions listed in https://docs.docker.com/engine/reference/commandline/cp/

TODO (low priority): Support stdio tar balls such as `nerdctl cp - DST` and `nerdctl cp SRC -`

Co-authored-by: fahed dorgaa <fahed.dorgaa@gmail.com>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
    @fahedouch @AkihiroSuda
    2 people authored and AkihiroSuda committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    85ca787 View commit details
    Browse the repository at this point in the history