Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.20 support to CI #30

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

austinvazquez
Copy link
Contributor

Update minimum Go version to Go 1.19 in go.mod. Update golangci-lint to
v1.51.x for Go 1.20 support.

Signed-off-by: Austin Vazquez macedonv@amazon.com

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023

Codecov Report

Base: 63.83% // Head: 64.00% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (ccf80f2) compared to base (19ab5f5).
Patch has no changes to coverable lines.

❗ Current head ccf80f2 differs from pull request most recent head e7e9e49. Consider uploading reports for the commit e7e9e49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   63.83%   64.00%   +0.16%     
==========================================
  Files           9        9              
  Lines        1800     1800              
==========================================
+ Hits         1149     1152       +3     
+ Misses        500      497       -3     
  Partials      151      151              
Impacted Files Coverage Δ
pkg/net/multiplex/mux.go 69.07% <0.00%> (+1.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@austinvazquez austinvazquez marked this pull request as ready for review February 24, 2023 05:38
@austinvazquez austinvazquez force-pushed the add-go-1.20-support branch 2 times, most recently from 2809097 to 3a37383 Compare February 24, 2023 15:46
@austinvazquez
Copy link
Contributor Author

Minor update to use env for setting go version so only have to update in one place.

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments .. cheers

@@ -40,14 +43,17 @@ jobs:

strategy:
matrix:
go-version: [1.19.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do this with a matrix I think.. e.g. go-version: [1.19.x, 1.20.x]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikebrow placed the matrix back in and same for testing. I know Go has it's never break backwards compatibility promise but I'm just so use to if I say I support it, then I better be testing it in the pipeline. But lmk if it gets too much. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust .. but verify!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@austinvazquez austinvazquez force-pushed the add-go-1.20-support branch 2 times, most recently from da98248 to c36e191 Compare February 25, 2023 03:53
Update minimum Go version to Go 1.19 in go.mod. Update golangci-lint to
v1.51.x for Go 1.20 support.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -40,14 +43,17 @@ jobs:

strategy:
matrix:
go-version: [1.19.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trust .. but verify!

@mikebrow mikebrow merged commit 2a8b655 into containerd:main Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants