-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.20 support to CI #30
Conversation
Codecov ReportBase: 63.83% // Head: 64.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
==========================================
+ Coverage 63.83% 64.00% +0.16%
==========================================
Files 9 9
Lines 1800 1800
==========================================
+ Hits 1149 1152 +3
+ Misses 500 497 -3
Partials 151 151
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2809097
to
3a37383
Compare
Minor update to use env for setting go version so only have to update in one place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple comments .. cheers
@@ -40,14 +43,17 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
go-version: [1.19.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's do this with a matrix I think.. e.g. go-version: [1.19.x, 1.20.x]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikebrow placed the matrix back in and same for testing. I know Go has it's never break backwards compatibility promise but I'm just so use to if I say I support it, then I better be testing it in the pipeline. But lmk if it gets too much. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trust .. but verify!
da98248
to
c36e191
Compare
Update minimum Go version to Go 1.19 in go.mod. Update golangci-lint to v1.51.x for Go 1.20 support. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
c36e191
to
e7e9e49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -40,14 +43,17 @@ jobs: | |||
|
|||
strategy: | |||
matrix: | |||
go-version: [1.19.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trust .. but verify!
Update minimum Go version to Go 1.19 in go.mod. Update golangci-lint to
v1.51.x for Go 1.20 support.
Signed-off-by: Austin Vazquez macedonv@amazon.com