gha: remove GOPATH and workingdir, update actions/setup-go@v4, actions/checkout@v4 #53
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 64.55% 64.61% +0.05%
==========================================
Files 9 9
Lines 1834 1834
==========================================
+ Hits 1184 1185 +1
+ Misses 499 498 -1
Partials 151 151 ☔ View full report in Codecov by Sentry. |
thaJeztah
force-pushed
the
gha_rm_workingdir
branch
from
ada781b
to
0296210
Compare
.github/workflows/ci.yml
Outdated
| path: src/github.com/containerd/nri | ||
| fetch-depth: 25 | ||
|
|
||
| - uses: containerd/project-checks@v1 | ||
| with: | ||
| working-directory: src/github.com/containerd/nri |
There was a problem hiding this comment.
Isn't this the culprit for the DCO check failure ?
There was a problem hiding this comment.
Yeah, I want to have a look why it still needs GOPATH. I could add it back for just this action, but perhaps we can fix that (it would save having to hard-code paths in github actions)
|
Looks like the containerd "project" action depends on GOPATH in some way; need to check why (and if we can fix that) |
Actually it is not the DCO check that failed but the file header check. And looking at the action it looks like it requires the |
We're only working with modules in this repo, so we should not have a need for this. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
gha_rm_workingdir
branch
from
0296210
to
ee96969
Compare
|
Yes, I spotted that working-dir "required" property in the project-check repository; so I think that could be related indeed. Guess I need to look more into that; in the meantime, I reverted the |
No description provided.