metrics: make it atomic for nydusd count

Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
containerd · Jan 19, 2023 · a4b21d7 · a4b21d7
1 parent 45b476a
commit a4b21d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pkg/manager/daemon_adaptor.go b/pkg/manager/daemon_adaptor.go
@@ -98,8 +98,8 @@ func (m *Manager) StartDaemon(d *daemon.Daemon) error {
 		}
 		d.Lock()
 		d.Version = daemonInfo.DaemonVersion()
-		d.Unlock()
 		collector.NewDaemonInfoCollector(&d.Version, 1).Collect()
+		d.Unlock()
 
 		if d.Supervisor == nil {
 			return

diff --git a/pkg/manager/manager.go b/pkg/manager/manager.go
@@ -520,7 +520,9 @@ func (m *Manager) DestroyDaemon(d *daemon.Daemon) error {
 	}
 
 	collector.NewDaemonEventCollector(types.DaemonStateDestroyed).Collect()
+	d.Lock()
 	collector.NewDaemonInfoCollector(&d.Version, -1).Collect()
+	d.Unlock()
 
 	return nil
 }