fix image builder ssl issue and trigger build on pull_request and release #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that ubuntu has decided to drop ca-certificates by default. So we missed it and curl would fail too. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
And tag each image with its release version, or use latest tag for master push. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
=======================================
Coverage 34.56% 34.56%
=======================================
Files 18 18
Lines 1270 1270
=======================================
Hits 439 439
Misses 760 760
Partials 71 71 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nydus-snapshotter:latestis built and pushed on each push to mainnydus-snapshotter:$release_tagis built and pushed on each release tagnydus-snapshotter:localis built on each pull request but not pushed, for testing purposeTested at https://github.com/bergwolf/nydus-snapshotter/actions/workflows/image.yml