Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scheme field in nydusd config #268

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

imeoer
Copy link
Collaborator

@imeoer imeoer commented Nov 30, 2022

remove scheme field in nydusd config

We have implemented automatically scheme detect for nydusd in this PR:

dragonflyoss/nydus#893 (comment)

So we can remove the default scheme field in nydusd config file.

@codecov-commenter
Copy link

Codecov Report

Base: 33.11% // Head: 33.02% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (40c5bd4) compared to base (dba3aaf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   33.11%   33.02%   -0.10%     
==========================================
  Files          29       29              
  Lines        3122     3122              
==========================================
- Hits         1034     1031       -3     
- Misses       1980     1983       +3     
  Partials      108      108              
Impacted Files Coverage Δ
pkg/blob/blob_manager.go 29.59% <0.00%> (-3.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@changweige
Copy link
Member

Seems no logic changes in this change set?

@liubogithub
Copy link
Contributor

Looks good for the 1st commit.

@changweige
Copy link
Member

We need to discuss the arrangement of currently scattered documents. I am inclining to merge this change until the nydusd (v2.2) including automatically changing HTTP scheme is released which means it can actually be used.

@changweige
Copy link
Member

Needs rebase. Can we only submit the changes for reference nydusd config file in this PR and clean up the docs in the next step?

We have implemented automatically scheme detect for nydusd in this PR:

dragonflyoss/nydus#893 (comment)

So we can remove the default scheme field in nydusd config file.

Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
@imeoer imeoer changed the title remove scheme field in nydusd config and improve doc remove scheme field in nydusd config Dec 8, 2022
@imeoer
Copy link
Collaborator Author

imeoer commented Dec 8, 2022

Needs rebase. Can we only submit the changes for reference nydusd config file in this PR and clean up the docs in the next step?

Ok, let's move forward first.

@changweige changweige merged commit 6e5f1fa into containerd:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants