Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve warnings in GitHub actions release workflow #270

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Resolve warnings in GitHub actions release workflow #270

merged 1 commit into from
Dec 1, 2022

Conversation

austinvazquez
Copy link
Contributor

Updates actions/checkout and actions/download-artifact packages from v2 to v3 to resolve NodeJS 12 warnings.

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Related issue: containerd/project#95

Signed-off-by: Austin Vazquez macedonv@amazon.com

Updates actions/checkout and actions/download-artifact packages from v2
to v3 to resolve NodeJS 12 warnings.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Base: 33.35% // Head: 33.09% // Decreases project coverage by -0.25% ⚠️

Coverage data is based on head (3bb6013) compared to base (1e18acb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
- Coverage   33.35%   33.09%   -0.26%     
==========================================
  Files          29       29              
  Lines        3124     3124              
==========================================
- Hits         1042     1034       -8     
- Misses       1974     1982       +8     
  Partials      108      108              
Impacted Files Coverage Δ
pkg/auth/kubesecret.go 27.64% <0.00%> (-8.95%) ⬇️
pkg/blob/blob_manager.go 32.65% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@austinvazquez austinvazquez marked this pull request as ready for review November 30, 2022 15:52
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@imeoer
Copy link
Collaborator

imeoer commented Dec 1, 2022

cc @changweige

@changweige changweige merged commit 600c0c9 into containerd:main Dec 1, 2022
@austinvazquez austinvazquez deleted the resolve-release-workflow-warnings branch December 1, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants