Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: support s3 backend #277

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

loheagn
Copy link
Contributor

@loheagn loheagn commented Dec 9, 2022

Signed-off-by: Nan Li loheagn@icloud.com

@loheagn
Copy link
Contributor Author

loheagn commented Dec 9, 2022

update dragonflyoss/nydus#831

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Base: 33.88% // Head: 31.48% // Decreases project coverage by -2.39% ⚠️

Coverage data is based on head (9038ab8) compared to base (3d0e02d).
Patch coverage: 12.63% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
- Coverage   33.88%   31.48%   -2.40%     
==========================================
  Files          30       34       +4     
  Lines        3223     3506     +283     
==========================================
+ Hits         1092     1104      +12     
- Misses       2019     2286     +267     
- Partials      112      116       +4     
Impacted Files Coverage Δ
pkg/backend/backend.go 0.00% <0.00%> (ø)
pkg/backend/oss.go 0.00% <0.00%> (ø)
pkg/backend/s3.go 13.04% <13.04%> (ø)
pkg/backend/localfs.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@loheagn
Copy link
Contributor Author

loheagn commented Dec 9, 2022

Hi, the CI seems to be blocked by something has nothing to do with this PR. Can anyone please help to rerun the failed job? Thanks :)

@changweige
Copy link
Member

How should we test it?

@loheagn
Copy link
Contributor Author

loheagn commented Dec 9, 2022

How should we test it?

I can add a new smoke test to this patch. The test will setup a minio server and execute image conversion using the minio server as s3 backend.

@changweige
Copy link
Member

How should we test it?

I can add a new smoke test to this patch. The test will setup a minio server and execute image conversion using the minio server as s3 backend.

It will be great to have such a test. Thanks

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @loheagn

@loheagn loheagn force-pushed the s3-backend branch 2 times, most recently from eb57346 to f5c1e5c Compare December 14, 2022 10:14
@loheagn
Copy link
Contributor Author

loheagn commented Dec 14, 2022

@changweige @imeoer Hi, I added a new smoke test to this patch to test the s3 backend. You can review the code again :)

@imeoer
Copy link
Collaborator

imeoer commented Dec 15, 2022

Signed-off-by: Nan Li <loheagn@icloud.com>
@loheagn
Copy link
Contributor Author

loheagn commented Dec 15, 2022

@loheagn It seems a data race be detected in https://github.com/containerd/nydus-snapshotter/actions/runs/3695539855/jobs/6258056733. :)

@imeoer Thanks for pointing the error! Tha data race was fixed.

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice test, thanks

@changweige changweige merged commit c27f809 into containerd:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants