-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend: support s3 backend #277
Conversation
update dragonflyoss/nydus#831 |
Codecov ReportBase: 33.88% // Head: 31.48% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
==========================================
- Coverage 33.88% 31.48% -2.40%
==========================================
Files 30 34 +4
Lines 3223 3506 +283
==========================================
+ Hits 1092 1104 +12
- Misses 2019 2286 +267
- Partials 112 116 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Hi, the CI seems to be blocked by something has nothing to do with this PR. Can anyone please help to rerun the failed job? Thanks :) |
How should we test it? |
I can add a new smoke test to this patch. The test will setup a minio server and execute image conversion using the minio server as s3 backend. |
It will be great to have such a test. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @loheagn
eb57346
to
f5c1e5c
Compare
@changweige @imeoer Hi, I added a new smoke test to this patch to test the s3 backend. You can review the code again :) |
@loheagn It seems a data race be detected in https://github.com/containerd/nydus-snapshotter/actions/runs/3695539855/jobs/6258056733. :) |
Signed-off-by: Nan Li <loheagn@icloud.com>
@imeoer Thanks for pointing the error! Tha data race was fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice test, thanks
Signed-off-by: Nan Li loheagn@icloud.com