config: add warmup option for nydus daemon #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 31.68% // Head: 31.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
==========================================
+ Coverage 31.68% 31.81% +0.13%
==========================================
Files 34 34
Lines 3576 3564 -12
==========================================
+ Hits 1133 1134 +1
+ Misses 2327 2314 -13
Partials 116 116
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
changweige
reviewed
Dec 30, 2022
config/daemonconfig/fuse.go
Outdated
| @@ -27,6 +27,7 @@ type FuseDaemonConfig struct { | |||
| EnableXattr bool `json:"enable_xattr,omitempty"` | |||
| AccessPattern bool `json:"access_pattern,omitempty"` | |||
| LatestReadFiles bool `json:"latest_read_files,omitempty"` | |||
| Warmup uint64 `json:"warmup"` | |||
There was a problem hiding this comment.
Please also add a comment line here to tell it's experimental.
This is an experimental feature. With the warmup option, the nydus daemon could cache more data on the local disk to increase hit ratio. Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
sctb512
force-pushed
the
support-warmup-config
branch
from
bce1db3
to
8bc7891
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental feature. With the warmup option, the nydus daemon could cache more data on the local disk to increase hit ratio.
Signed-off-by: Bin Tang tangbin.bin@bytedance.com