metrics: avoid to collect inflight metrics for fscache driver #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sctb512
changed the title
Similar to FS metrics. The metrics for /api/v1/metrics/inflight are in the RAFS of nydus daemon. When the driver is fscache, there are no metrics in RAFS. Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
sctb512
force-pushed
the
avoid-collect-inflight-metrics
branch
from
76c89a4
to
915190c
Compare
Codecov ReportBase: 30.50% // Head: 30.50% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #317 +/- ##
=======================================
Coverage 30.50% 30.50%
=======================================
Files 37 37
Lines 3800 3800
=======================================
Hits 1159 1159
Misses 2520 2520
Partials 121 121 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to FS metrics. The metrics for /api/v1/metrics/inflight are in the RAFS of nydus daemon.
When the driver is fscache, there are no metrics in RAFS.
Signed-off-by: Bin Tang tangbin.bin@bytedance.com