Remove CLI K8s auth passing related parameters #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 29.53% // Head: 28.99% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 29.53% 28.99% -0.54%
==========================================
Files 37 37
Lines 3718 3704 -14
==========================================
- Hits 1098 1074 -24
- Misses 2500 2510 +10
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
changweige
force-pushed
the
remove-more-cli-parameters-2
branch
5 times, most recently
from
9c88a56
to
547606a
Compare
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
They should configured in new TOML based configuration file now. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
remove-more-cli-parameters-2
branch
from
547606a
to
02475bd
Compare
|
@changweige Thanks for reminding 😀 I'll try to update and test our deployment after this PR is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this phase, we are going to remove K8s auth passing related parameters and suggest users to migrate to nydus-snapshotter's toml configuration file to achieve it