Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move metrics config to a separated section #335

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

changweige
Copy link
Member

We are pursuing a more fine-grained configuration section for metrcis, e.g. scrape interval, etc

Signed-off-by: Changwei Ge gechangwei@bytedance.com

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@codecov-commenter
Copy link

Codecov Report

Base: 28.99% // Head: 28.97% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (04309e3) compared to base (69c9c6b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   28.99%   28.97%   -0.03%     
==========================================
  Files          37       37              
  Lines        3704     3707       +3     
==========================================
  Hits         1074     1074              
- Misses       2510     2513       +3     
  Partials      120      120              
Impacted Files Coverage Δ
config/config.go 9.00% <0.00%> (-0.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants