Remove the other cli parameters #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Codecov ReportBase: 28.97% // Head: 28.30% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #336 +/- ##
==========================================
- Coverage 28.97% 28.30% -0.67%
==========================================
Files 37 37
Lines 3707 3674 -33
==========================================
- Hits 1074 1040 -34
- Misses 2513 2514 +1
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
changweige
force-pushed
the
remove-other-cli-parameters
branch
from
94781b3
to
43874f8
Compare
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
remove-other-cli-parameters
branch
from
43874f8
to
1eadfda
Compare
imeoer
reviewed
Jan 30, 2023
config/default.go
Outdated
| @@ -61,6 +61,7 @@ func (c *SnapshotterConfig) FillUpWithDefaults() error { | |||
| if daemonConfig.NydusdConfigPath == "" { | |||
| daemonConfig.NydusdConfigPath = defaultNydusDaemonConfigPath | |||
| } | |||
| daemonConfig.RecoverPolicy = "restart" | |||
There was a problem hiding this comment.
Maybe make restart, failover as constant?
There was a problem hiding this comment.
We already have the ReoverPolicy custom type definition which is an alias of int. So let's use the parse String() method here rather literal string
|
others LGTM. |
It is a more sutible package to accommodate the logics Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this stage, we're going the remove other not frequently used CLI parameters and let e2e test adapt it.