let fscache driver enforce shared daemon mode forcefully #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will be more friendly to users by hiding some inner details Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
|
@hsiangkao Please take a glance |
imeoer
reviewed
Jan 31, 2023
| @@ -93,6 +94,12 @@ func ProcessConfigurations(c *SnapshotterConfig) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| if c.DaemonConfig.FsDriver == FsDriverFscache && m != DaemonModeShared { | |||
| log.L.Infof("fscache driver must enforce \"shared\" daemon mode, change it forcefully from %s", m) | |||
There was a problem hiding this comment.
Better to be a warning message?
There was a problem hiding this comment.
Okay ignore me, it makes sense.
Codecov ReportBase: 28.30% // Head: 28.33% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 28.30% 28.33% +0.02%
==========================================
Files 37 37
Lines 3674 3671 -3
==========================================
Hits 1040 1040
+ Misses 2514 2510 -4
- Partials 120 121 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
imeoer
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be more friendly to users by hiding some inner details
Signed-off-by: Changwei Ge gechangwei@bytedance.com