add brief introduction on metrics and diagnose methods #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 28.25% // Head: 28.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage 28.25% 28.25%
=======================================
Files 37 37
Lines 3667 3667
=======================================
Hits 1036 1036
Misses 2510 2510
Partials 121 121 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sctb512
reviewed
Feb 6, 2023
docs/configure_nydus.md
Outdated
|
|
||
| ## Diagnose | ||
|
|
||
| By setting `enable_system_controller` to `true`, nydus-snapshotter will start a simple HTTP serve on unix domain socket `$ROOT/system.sock` and exports some internal working status to users. |
There was a problem hiding this comment.
Maybe we need to update it for new configuration items because another PR is modifying them.
There was a problem hiding this comment.
Seasonable, let's mark this PR as draft for now and waiting for another PR being merged
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
imeoer
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As tittled