mark stargz configuration as experimental #346
Conversation
Codecov ReportBase: 28.25% // Head: 28.25% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 28.25% 28.25%
=======================================
Files 37 37
Lines 3667 3667
=======================================
Hits 1036 1036
Misses 2510 2510
Partials 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
config/config.go
Outdated
| @@ -175,6 +178,7 @@ type SnapshotterConfig struct { | |||
| ImageConfig ImageConfig `toml:"image"` | |||
| CacheManagerConfig CacheManagerConfig `toml:"cache_manager"` | |||
| LoggingConfig LoggingConfig `toml:"log"` | |||
| Experimental Experimental `toml:"experimental"` | |||
There was a problem hiding this comment.
Will it move out once the feature becomes ready?
There was a problem hiding this comment.
Yes. We will move it out when it's ready. In fact, the stargz compibility feature has malfunctioned for quite a time.
There was a problem hiding this comment.
How do we ensure the CLI flags compatibility when moving it out?
There was a problem hiding this comment.
CLI does not has --enable-stargz flag now. and stargz feature has malfunctioned for a long time with stable nydusd release. So I suppose we don't have to worry about compatiblity.
| @@ -93,6 +93,10 @@ const ( | |||
| FsDriverFscache string = "fscache" | |||
| ) | |||
|
|
|||
| type Experimental struct { | |||
There was a problem hiding this comment.
Could we add a description of experimental in the related document and an example in toml?
There was a problem hiding this comment.
Good point, already changed the example toml configuraion file
changweige
force-pushed
the
mark-stargz-as-experimental
branch
from
1b50dfe
to
f6d9be0
Compare
|
Need to be rebased. |
As the stargz compatiblity feature is not production ready and reliable enought. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
mark-stargz-as-experimental
branch
from
f6d9be0
to
8b3f9db
Compare
Rebased. Thanks. |
As the stargz compatiblity feature is not production ready
and reliable enought
Signed-off-by: Changwei Ge gechangwei@bytedance.com