Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update daemon version when getting state #348

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

sctb512
Copy link
Member

@sctb512 sctb512 commented Feb 6, 2023

Signed-off-by: Bin Tang tangbin.bin@bytedance.com

@sctb512 sctb512 changed the title [wip]update daemon version when getting state update daemon version when getting state Feb 6, 2023
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
@codecov-commenter
Copy link

Codecov Report

Base: 29.36% // Head: 29.36% // No change to project coverage 👍

Coverage data is based on head (7e5aa93) compared to base (fcca6f9).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   29.36%   29.36%           
=======================================
  Files          38       38           
  Lines        3801     3801           
=======================================
  Hits         1116     1116           
  Misses       2553     2553           
  Partials      132      132           
Impacted Files Coverage Δ
pkg/daemon/daemon.go 0.00% <0.00%> (ø)
pkg/manager/daemon_adaptor.go 0.00% <ø> (ø)
pkg/manager/manager.go 18.15% <0.00%> (-0.19%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@changweige changweige merged commit 75493b1 into containerd:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants