export label and handler defined in containerd #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
See containerd/containerd#8054 Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
label-handler
branch
from
49babc0
to
d959c58
Compare
Codecov ReportBase: 29.28% // Head: 29.36% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 29.28% 29.36% +0.07%
==========================================
Files 38 38
Lines 3811 3811
==========================================
+ Hits 1116 1119 +3
+ Misses 2563 2560 -3
Partials 132 132
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
changweige
reviewed
Feb 13, 2023
| // For package compatibility, we still keep the old exported name here. | ||
| var AppendLabelsHandlerWrapper = snpkg.AppendInfoHandlerWrapper | ||
|
|
||
| // For package compatibility, we still keep the old exported name here. |
There was a problem hiding this comment.
This compatibility trick looks good to me. Hopefully, we can update this package's consumer to let them directly import containerd/snapshotters packge.
changweige
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See containerd/containerd#8054