Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print instance image id from system diagnose API #366

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

changweige
Copy link
Member

In order to print more info about image instance to help analyze

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@codecov-commenter
Copy link

Codecov Report

Base: 29.24% // Head: 29.30% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (366f3e8) compared to base (aaed554).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   29.24%   29.30%   +0.06%     
==========================================
  Files          38       38              
  Lines        3813     3815       +2     
==========================================
+ Hits         1115     1118       +3     
+ Misses       2566     2565       -1     
  Partials      132      132              
Impacted Files Coverage Δ
pkg/system/system.go 6.31% <0.00%> (-0.07%) ⬇️
pkg/blob/blob_manager.go 32.65% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit b26eedd into containerd:main Feb 23, 2023
@changweige changweige deleted the system-diagnose-print-image-id branch February 27, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants