Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix system controller default socket address #367

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

changweige
Copy link
Member

The default address should locate at
/var/run/containerd-nydus/system.sock

The default address should locate at
/var/run/containerd-nydus/system.sock

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@codecov-commenter
Copy link

Codecov Report

Base: 29.24% // Head: 29.24% // No change to project coverage 👍

Coverage data is based on head (cd29966) compared to base (aaed554).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #367   +/-   ##
=======================================
  Coverage   29.24%   29.24%           
=======================================
  Files          38       38           
  Lines        3813     3813           
=======================================
  Hits         1115     1115           
  Misses       2566     2566           
  Partials      132      132           
Impacted Files Coverage Δ
config/default.go 0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit 16ca123 into containerd:main Feb 22, 2023
@changweige changweige deleted the fix-system-default-socket branch February 27, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants