upgrade project's golang version to 1.19.6 #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changweige
force-pushed
the
upgrade-golang
branch
from
448e365
to
c171a4a
Compare
Codecov ReportBase: 29.24% // Head: 29.24% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 29.24% 29.24%
=======================================
Files 38 38
Lines 3813 3813
=======================================
Hits 1115 1115
Misses 2566 2566
Partials 132 132 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Thus to catch up with containerd Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
upgrade-golang
branch
from
c171a4a
to
7b32b0c
Compare
imeoer
reviewed
Feb 23, 2023
| @@ -15,7 +15,7 @@ jobs: | |||
| - name: Set up Go | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: "1.19.1" | |||
| go-version: "1.20.1" | |||
There was a problem hiding this comment.
No. For golangci-lint, we'd like to use a higher version of golang thus to allow it to report more warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus to catch up with containerd